Global Styles: Add slashes back to the Theme JSON (#33919)

* Global Styles: Add slashes back to the Theme JSON * Change PHP strip/add slashes to use the WordPress functions * Add a unit test for global styles * fix typo
WordPress · Aug 12, 2021 · 1e50cab · 1e50cab
1 parent ae56763
commit 1e50cab
Show file tree

Hide file tree

Showing 2 changed files with 30 additions and 2 deletions.
diff --git a/lib/global-styles.php b/lib/global-styles.php
@@ -232,7 +232,7 @@ function gutenberg_experimental_global_styles_register_user_cpt() {
  * @return string Filtered post content with unsafe rules removed.
  */
 function gutenberg_global_styles_filter_post( $content ) {
-	$decoded_data        = json_decode( stripslashes( $content ), true );
+	$decoded_data        = json_decode( wp_unslash( $content ), true );
 	$json_decoding_error = json_last_error();
 	if (
 		JSON_ERROR_NONE === $json_decoding_error &&
@@ -245,7 +245,7 @@ function gutenberg_global_styles_filter_post( $content ) {
 		$data_to_encode = WP_Theme_JSON_Gutenberg::remove_insecure_properties( $decoded_data );
 
 		$data_to_encode['isGlobalStylesUserThemeJSON'] = true;
-		return wp_json_encode( $data_to_encode );
+		return wp_slash( wp_json_encode( $data_to_encode ) );
 	}
 	return $content;
 }

diff --git a/phpunit/global-styles-test.php b/phpunit/global-styles-test.php
@@ -0,0 +1,28 @@
+<?php
+
+/**
+ * Test the Global Styles lib
+ *
+ * @package Gutenberg
+ */
+
+class WP_Global_Styles_Test extends WP_UnitTestCase {
+	function test_gutenberg_global_styles_filter_post() {
+		$user_theme_json = '{
+			"isGlobalStylesUserThemeJSON": 1,
+			"version": 1,
+			"settings": {
+				"typography": {
+					"fontFamilies": {
+						"fontFamily": "\"DM Sans\", sans-serif",
+						"slug": "dm-sans",
+						"name": "DM Sans",
+					}
+				}
+			}
+		}';
+
+		$filtered_user_theme_json = gutenberg_global_styles_filter_post( $user_theme_json );
+		$this->assertEquals( $user_theme_json, $filtered_user_theme_json );
+	}
+}