Skip to content

Commit

Permalink
Performance Tests Workflow: Use latest WP branch for release tests (#…
Browse files Browse the repository at this point in the history
…32277)

As Riad mentioned in Slack:

> [R]elease perf jobs are breaking https://github.com/WordPress/gutenberg/runs/2676154517?check_suite_focus=true. If I have to guess, I think it's because the base WP install used comes from trunk and the fixes for the conflicts introduced so solve the conflicts are not included in both the previous release's branch and `wp/5.7` branch. Ideal fix would be to rely on the `5.7` (previous wp release) as base branch instead of latest trunk like all the e2e tests jobs.

Turns out the performance script has a `--tests-branch` arg that is already used to set the branch from which we run the WP env for those tests.
  • Loading branch information
ockham authored May 27, 2021
1 parent 91ed69e commit 14a52d8
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/performance.yml
Original file line number Diff line number Diff line change
Expand Up @@ -56,4 +56,4 @@ jobs:
WP_VERSION=$(grep -oP "$TESTED_UP_TO_REGEX" ./readme.txt)
IFS='.' read -r -a WP_VERSION_ARRAY <<< "$WP_VERSION"
WP_BRANCH="wp/${WP_VERSION_ARRAY[0]}.${WP_VERSION_ARRAY[1]}"
./bin/plugin/cli.js perf --ci $WP_BRANCH $PREVIOUS_RELEASE_BRANCH $CURRENT_RELEASE_BRANCH
./bin/plugin/cli.js perf --ci $WP_BRANCH $PREVIOUS_RELEASE_BRANCH $CURRENT_RELEASE_BRANCH --tests-branch $WP_BRANCH

0 comments on commit 14a52d8

Please sign in to comment.