Skip to content

Commit

Permalink
elevate scrollEnabled prop to BlockList (#21505)
Browse files Browse the repository at this point in the history
  • Loading branch information
jbinda authored Apr 16, 2020
1 parent 2f33495 commit 13f244b
Show file tree
Hide file tree
Showing 5 changed files with 1 addition and 9 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,6 @@ export class BlockList extends Component {
isReadOnly,
isRootList,
horizontal,
scrollEnabled,
shouldShowInsertionPointBefore,
shouldShowInsertionPointAfter,
marginVertical = styles.defaultBlock.marginTop,
Expand Down Expand Up @@ -140,7 +139,7 @@ export class BlockList extends Component {
! isRootList && styles.overflowVisible,
] }
horizontal={ horizontal }
scrollEnabled={ scrollEnabled }
scrollEnabled={ isRootList }
contentContainerStyle={
horizontal && styles.horizontalContentContainer
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,6 @@ class InnerBlocks extends Component {
renderAppender,
__experimentalMoverDirection,
horizontal,
scrollEnabled,
contentResizeMode,
contentStyle,
onAddBlock,
Expand All @@ -137,7 +136,6 @@ class InnerBlocks extends Component {
__experimentalMoverDirection
}
horizontal={ horizontal }
scrollEnabled={ scrollEnabled }
contentResizeMode={ contentResizeMode }
contentStyle={ contentStyle }
onAddBlock={ onAddBlock }
Expand Down
1 change: 0 additions & 1 deletion packages/block-library/src/column/edit.native.js
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,6 @@ function ColumnEdit( {
] }
>
<InnerBlocks
scrollEnabled={ false }
renderAppender={
isSelected && InnerBlocks.ButtonBlockAppender
}
Expand Down
1 change: 0 additions & 1 deletion packages/block-library/src/columns/edit.native.js
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,6 @@ function ColumnsEditContainer( {
columnsInRow > 1 ? 'horizontal' : undefined
}
horizontal={ true }
scrollEnabled={ false }
allowedBlocks={ ALLOWED_BLOCKS }
contentResizeMode="stretch"
onAddBlock={ onAddNextColumn }
Expand Down
3 changes: 0 additions & 3 deletions packages/block-library/src/group/edit.native.js
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,6 @@ function GroupEdit( { hasInnerBlocks, isSelected, getStylesFromColorScheme } ) {
<View style={ isSelected && hasInnerBlocks && styles.innerBlocks }>
<InnerBlocks
renderAppender={ isSelected && InnerBlocks.ButtonBlockAppender }
flatListProps={ {
scrollEnabled: false,
} }
/>
</View>
);
Expand Down

0 comments on commit 13f244b

Please sign in to comment.