Navigation Screen: Hide sidebar menu isn't selected (#32090)

* Fix the visual glitch
WordPress · May 25, 2021 · 10b6189 · 10b6189
1 parent 0616cf0
commit 10b6189
Showing 1 changed file with 11 additions and 9 deletions.
diff --git a/packages/edit-navigation/src/components/layout/index.js b/packages/edit-navigation/src/components/layout/index.js
@@ -94,7 +94,7 @@ export default function Layout( { blockEditorSettings } ) {
 	useMenuNotifications( selectedMenuId );
 
 	const hasMenus = !! menus?.length;
-	const hasPermanentSidebar = isLargeViewport && hasMenus;
+	const hasPermanentSidebar = isLargeViewport && isMenuSelected;
 
 	const isBlockEditorReady = !! (
 		hasMenus &&
@@ -183,14 +183,16 @@ export default function Layout( { blockEditorSettings } ) {
 								)
 							}
 						/>
-						<Sidebar
-							onSelectMenu={ selectMenu }
-							menus={ menus }
-							menuId={ selectedMenuId }
-							onDeleteMenu={ deleteMenu }
-							isMenuBeingDeleted={ isMenuBeingDeleted }
-							hasPermanentSidebar={ hasPermanentSidebar }
-						/>
+						{ isMenuSelected && (
+							<Sidebar
+								menus={ menus }
+								menuId={ selectedMenuId }
+								onSelectMenu={ selectMenu }
+								onDeleteMenu={ deleteMenu }
+								isMenuBeingDeleted={ isMenuBeingDeleted }
+								hasPermanentSidebar={ hasPermanentSidebar }
+							/>
+						) }
 					</IsMenuNameControlFocusedContext.Provider>
 					<UnsavedChangesWarning />
 				</BlockEditorProvider>