v1 custom post type #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamziel
reviewed
Apr 12, 2024
|
Let's rename |
add missing /trunk/ in URL Co-authored-by: Adam Zielinski <[email protected]>
adamziel
reviewed
Apr 12, 2024
adamziel
reviewed
Apr 12, 2024
blueprints/custom-post/books.txt
Outdated
| 'label' => __( 'Book', 'gbt' ), | ||
| 'description' => __( 'Books', 'gbt' ), | ||
| 'labels' => $labels, | ||
| 'supports' => array( 'title', 'editor', excerpt, featured_image), |
There was a problem hiding this comment.
I'm getting PHP Fatal error: Uncaught Error: Undefined constant "excerpt" here
There was a problem hiding this comment.
Ah, I made changes after I tested it myself. 🤦♀️ I removed supports excerpt and featured image
use relative path correctly. Co-authored-by: Adam Zielinski <[email protected]>
|
@adamziel The reason I used books.txt was that my test directory is in an I tested it all again, and all seems to be fixed now. |
adamziel
reviewed
Apr 12, 2024
correction of referenced file Co-authored-by: Adam Zielinski <[email protected]>
…into custom-post
remove files not belonging to this branch.
|
Perfect, thank you! |
reimic
pushed a commit
to reimic/blueprints-library-ci
that referenced
this pull request
Jun 11, 2024
…ma (#23) Solves the Blueprint parsing problem as follows: * JSON Schema is the source of truth for the Blueprint data structure * Model classes are generated from JSON Schema * Input Validation is done against the JSON Schema * Mapping validated input into model instances is indirectly done based on the JSON Schema ## Summary of the approach We use [Janephp](https://github.com/janephp/janephp/) to infer the PHP model class structure from the JSON schema We then use Jane's output to generate PHP code using [Nette PHP generator](https://github.com/nette/php-generator): * Model classes * Interfaces for groups of related classes: `StepDefinitionInterface`, `ResourceDefinitionInterface`. * Interface resolution map for the [JsonMapper library](https://jsonmapper.net/). * PHP docstrings with more accurate types than Jane to guide the mapping process From there, the data pipeline looks as follows: 1. Parse raw JSON 2. Validate it with Opis 3. Map it into PHP models using JsonMapper Or, if you're consuming the PHP API directly: 1. Create Model instances 2. Validate them with Opis ## Remaining work - [ ] Solve merge conflicts ## Rationale Parsing and mapping JSON [in TypeScript is a simple problem, but in PHP it's surprisingly involved](WordPress/blueprints#13 (comment)). This PR combines three previously explored approaches into a single pipeline: * WordPress/blueprints#17 * WordPress/blueprints#19 * WordPress/blueprints#21
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blueprint
Enable the user of playground to create posts with certain custom post type, and create single post and archive templates for this post type.
Also props to @ryanwelcher
It's v1