WIP: Introduce directive processor #158

dmsnell · 2023-02-21T22:04:43Z

The directive processor builds on the HTML Tag Processor to provide additional functionality, assuming normative markup generated from React, assuming that all tag directives contain a balanced closer.

This will break in practice, and is probably entirely wrong as-is. The purpose of this commit is to introduce the idea and explore using the code to get a feel for whether it will work.

adamziel · 2023-02-22T18:36:54Z

src/class-wp-directive-processor.php

+		return false;
+	}
+
+	public function get_inner_html() {


It's only get_inner_html if we assume normative markup. I'd suggest this:

Suggested change

public function get_inner_html() {

public function get_balanced_tags_html() {

Alternatively, we could return false in next_balanced_closer if it detects any misnesting.

Also, the current tag is a void element.

thanks @adamziel - while not in the comments (but found in the commit message), because I was tossing this together quite quickly, I was taking this file to assume certain things:

assuming normative markup generated from React, assuming that all tag directives contain a balanced closer.

so my idea was simply to write it as if that were true and we can treat deviations as bugs. I don't think any of the directives are self-closing foreign elements, though if they are we can add that support.

this is more or less my exploration of a client API where I consider strictness needs to be lower overall. e.g. if we're looking for the inner HTML of a wp-context then it won't matter if we have void tags or unbalanced tags. everything inside of the directives is blank since we're jumping straight to the next wp-context tag.

If the markup is supposed to be normative then there should be no harm in baling out in case misnesting is detected?

But then again, assuming everything inside a directive is skippable like text means there’s no need to do these checks

we can't assume the contents are Text/Data. in fact, we expect them to be HTML, which means we still need to scan them to avoid the conflation of things like <wp-show><textarea>Use <wp-show when="…"> to conditionally show things</textarea></wp-show>

adamziel · 2023-02-22T18:37:54Z

src/class-wp-directive-processor.php

+		return substr( $this->html, $start, $end - $start );
+	}
+
+	public function set_inner_html( $new_html ) {


Ditto

Suggested change

public function set_inner_html( $new_html ) {

public function set_balanced_tags_html( $new_html ) {

adamziel · 2023-02-22T18:39:11Z

src/class-wp-directive-processor.php

+			$this->release_bookmark( 'start' );
+			return false;
+		}
+		$this->set_bookmark( 'end' );


Bookmarking tag closers is affected by a bug, here's a fix:

WordPress/wordpress-develop#4115

excellent catch and excellent fix! I didn't test any of the code I wrote here, or even check if it's statically correct.

adamziel · 2023-02-22T18:39:59Z

This will break in practice, and is probably entirely wrong as-is

@dmsnell I left a few comments but I don't see anything fundamentally wrong here. The first draft is strong.

The directive processor builds on the HTML Tag Processor to provide additional functionality, assuming normative markup generated from React, assuming that all tag directives contain a balanced closer. This will break in practice, and is probably entirely wrong as-is. The purpose of this commit is to introduce the idea and explore using the code to get a feel for whether it will work.

adamziel · 2023-03-02T15:17:15Z