Switch to PHPCSStandards/PHP_CodeSniffer & raise minimum supported version #2408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrfnl
added
Status: Requirement not met
jrfnl
changed the title
GaryJones
approved these changes
Dec 3, 2023
jrfnl
force-pushed
the
feature/switch-to-fork-of-phpcs
branch
from
74c4ed9
to
2b33752
Compare
|
Rebased without changes to get it passed a merge conflict. |
This was referenced Dec 4, 2023
jrfnl
force-pushed
the
feature/switch-to-fork-of-phpcs
branch
from
2b33752
to
d488b71
Compare
|
Update: The Composer package name will not change, so while this PR should still be merged at our convenience (after the 3.8.0 release expected this Friday), we will not need to do a release to unblock end-users. (though we may want to do a release anyway, but not for reasons related to this PR) |
jrfnl
removed
the
Status: Requirement not met
|
PHPCS 3.8.0 has been released. (as well as PHPCSUtils 1.0.9 + PHPCSExtra 1.2.1) Marking this PR as ready for review. |
|
I've merged #2412. You can rebase and I'll approve and merge this PR 👍🏼 |
The Squizlabs repo has been abandoned. The project continues in a fork in the PHPCSStandards organisation. Ref: * squizlabs/PHP_CodeSniffer 3932
In contrast to earlier information, arrangements are now being made to allow the package to continue under its original name on Packagist. The commit (in the new repo) to rename the package [has been reverted](PHPCSStandards/PHP_CodeSniffer#135).
... for improved PHP 8.2 support.
... after the tooling has also updated to the PHPCSStandards version of PHPCS. Refs: * https://github.com/PHPCSStandards/PHPCSUtils/releases * https://github.com/PHPCSStandards/PHPCSExtra/releases
... as the bug is now fixed.
jrfnl
force-pushed
the
feature/switch-to-fork-of-phpcs
branch
from
00bb218
to
105a10c
Compare
|
Rebased, 🤞🏻 for a passing build. |
|
And... we have lift-off.... 🚀 |
dingo-d
approved these changes
Dec 10, 2023
This was referenced Dec 12, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(which contains the Composer, this can/should be mergedreplacedirective)and released ASAP.Switch to PHPCSStandards/PHP_CodeSniffer
The Squizlabs repo has been abandoned. The project continues in a fork in the PHPCSStandards organisation.
Ref:
🆕 Revert changes to the Composer package name
In contrast to earlier information, arrangements are now being made to allow the package to continue under its original name on Packagist. The commit (in the new repo) to rename the package has been reverted.
Composer: raise the minimum supported PHPCS version to 3.8.0
... ... for improved PHP 8.2 support.
Includes updating references to the PHPCS version whenever relevant throughout the codebase.
Composer: update various version constraints
... after the tooling has also updated to the PHPCSStandards version of PHPCS.
Refs:
🆕 DeprecatedFunctionsUnitTest: remove work-around for PHPCS bug
... as the bug is now fixed.