Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Travis: change from "trusty" to "xenial" #1940

Merged
merged 1 commit into from
Jul 22, 2020
Merged

Travis: change from "trusty" to "xenial" #1940

merged 1 commit into from
Jul 22, 2020

Conversation

jrfnl
Copy link
Member

@jrfnl jrfnl commented Jul 22, 2020

As the "trusty" environment is no longer officially supported by Travis, they decided in their wisdom to silently stop updating the PHP "nightly" image, which makes it next to useless as the last image apparently is from January....

This updates the Travis config to:

  • Use the xenial distro, which at this time is the default.
  • Sets the distro for low PHP versions explicitly to trusty.
  • Makes the expected OS explicit (linux).

@jrfnl
Travis: change from "trusty" to "xenial"
0265236 
As the "trusty" environment is no longer officially supported by Travis, they decided in their wisdom to silently stop updating the PHP "nightly" image, which makes it next to useless as the last image apparently is from January....

This updates the Travis config to:
* Use the `xenial` distro, which at this time is the default.
* Sets the distro for low PHP versions explicitly to `trusty`.
* Makes the expected OS explicit (linux).
@jrfnl jrfnl added this to the 3.0.0 milestone Jul 22, 2020
GaryJones
GaryJones approved these changes Jul 22, 2020
View reviewed changes
Copy link
Member

@GaryJones GaryJones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, though it does now show that there are some failures for PHP 8.

@jrfnl
Copy link
Member Author

jrfnl commented Jul 22, 2020

Approving, though it does now show that there are some failures for PHP 8.

@GaryJones Yes, sorry, I should have mentioned that.

  1. All the more reason for the switch over as otherwise we wouldn't be notified of those impending failures.
  2. I did look at those failures briefly, and while I haven't tested to confirm, I expect these all to be related to the PHP 8 change in how comments are tokenized.
    There is a PR open in PHPCS itself to fix the tokenization to be stable across versions. That PR is actually how I discovered the issue with the trusty images on Travis ;-)
    I expect the build will pass (for dev-master) again once that upstream PR has been merged.

@GaryJones GaryJones merged commit 37b0653 into develop Jul 22, 2020
@GaryJones GaryJones deleted the feature/update-travis-env branch July 22, 2020 20:50
@jrfnl
Copy link
Member Author

jrfnl commented Jul 23, 2020

FYI: the upstream PR for the PHP 8 comment tokenization has been merged, I restarted the last develop / nightly / PHPCS dev-master build and as expected, that build now passes for the comment issues, though it does show there is still another issue to investigate (might be an upstream issue, I'll investigate): https://travis-ci.com/github/WordPress/WordPress-Coding-Standards/jobs/364009318

@jrfnl
Copy link
Member Author

jrfnl commented Jul 23, 2020

Pulled a PR upstream to fix that last issue: squizlabs/PHP_CodeSniffer#3033

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dingo-d dingo-d dingo-d approved these changes

@GaryJones GaryJones GaryJones approved these changes

Assignees
No one assigned
Labels
Type: Chores/Cleanup
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jrfnl @GaryJones @dingo-d