Skip to content

Commit

Permalink
Composer: raise the minimum supported PHPCS version to 3.8.0
Browse files Browse the repository at this point in the history
... to prevent end-users from running into trouble with the name change.

The files in the Composer `vendor/bin` will only be replaced when the `replace...` directive is found and that is only available in the 3.8.0 tag.
When the files in the Composer `vendor/bin` are not replaced, they will continue to point to the `vendor/squizlabs/php_codesniffer` directory which will no longer exist, leading to fatal "File not found" errors for end-users trying to run PHPCS/PHPCBF.

Includes updating references to the PHPCS version whenever relevant throughout the codebase.
  • Loading branch information
jrfnl committed Dec 3, 2023
1 parent 6bf2569 commit 1b66722
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .github/CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ When you introduce new `public` sniff properties, or your sniff extends a class

## Pre-requisites
* WordPress-Coding-Standards
* PHP_CodeSniffer 3.7.2 or higher
* PHP_CodeSniffer 3.8.0 or higher
* PHPCSUtils 1.0.8 or higher
* PHPCSExtra 1.2.0 or higher
* PHPUnit 4.x, 5.x, 6.x or 7.x
Expand Down
2 changes: 1 addition & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
"ext-libxml": "*",
"ext-tokenizer": "*",
"ext-xmlreader": "*",
"phpcsstandards/php_codesniffer": "^3.7.2",
"phpcsstandards/php_codesniffer": "^3.8.0",
"phpcsstandards/phpcsutils": "^1.0.8",
"phpcsstandards/phpcsextra": "^1.2.0"
},
Expand Down

0 comments on commit 1b66722

Please sign in to comment.