Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2.0.9 #841

Merged
merged 5 commits into from
Nov 8, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/cs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:

steps:
- name: Checkout code
uses: actions/checkout@v2
uses: actions/checkout@v4

- name: Install PHP
uses: shivammathur/setup-php@v2
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ jobs:

steps:
- name: Checkout code
uses: actions/checkout@v2
uses: actions/checkout@v4

- name: Install PHP
uses: shivammathur/setup-php@v2
Expand Down
16 changes: 8 additions & 8 deletions .github/workflows/quicktest.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ jobs:

steps:
- name: Checkout code
uses: actions/checkout@v2
uses: actions/checkout@v4

- name: Install PHP
uses: shivammathur/setup-php@v2
Expand All @@ -53,16 +53,22 @@ jobs:
- name: Setup Python
uses: actions/setup-python@v2
with:
python-version: '3.8'
python-version: '3.10'

- name: Setup proxy server
run: pip3 install mitmproxy

- name: Check mitmproxy version
run: mitmdump --version

- name: Start test server
run: |
PORT=8080 vendor/bin/start.sh
echo "REQUESTS_TEST_HOST_HTTP=localhost:8080" >> $GITHUB_ENV

- name: Ping localhost domain
run: ping -c1 localhost

- name: Start proxy server
run: |
PORT=9002 tests/utils/proxy/start.sh
Expand All @@ -75,12 +81,6 @@ jobs:
- name: Ensure the HTTPS test instance on Render is spun up
run: curl -s -I https://requests-test-server.onrender.com/ > /dev/null

- name: Check mitmproxy version
run: mitmdump --version

- name: Ping localhost domain
run: ping -c1 localhost

- name: Access localhost on port 8080
run: curl -i http://localhost:8080

Expand Down
16 changes: 8 additions & 8 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ jobs:

steps:
- name: Checkout code
uses: actions/checkout@v2
uses: actions/checkout@v4

- name: Install PHP
uses: shivammathur/setup-php@v2
Expand Down Expand Up @@ -67,16 +67,22 @@ jobs:
- name: Setup Python
uses: actions/setup-python@v2
with:
python-version: '3.8'
python-version: '3.10'

- name: Setup proxy server
run: pip3 install mitmproxy

- name: Check mitmproxy version
run: mitmdump --version

- name: Start test server
run: |
PORT=8080 vendor/bin/start.sh
echo "REQUESTS_TEST_HOST_HTTP=localhost:8080" >> $GITHUB_ENV

- name: Ping localhost domain
run: ping -c1 localhost

- name: Start proxy server
run: |
PORT=9002 tests/utils/proxy/start.sh
Expand All @@ -89,12 +95,6 @@ jobs:
- name: Ensure the HTTPS test instance on Render is spun up
run: curl -s -I https://requests-test-server.onrender.com/ > /dev/null

- name: Check mitmproxy version
run: mitmdump --version

- name: Ping localhost domain
run: ping -c1 localhost

- name: Access localhost on port 8080
run: curl -i http://localhost:8080

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/update-cacert.yml
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ jobs:
fi
- name: Checkout code
uses: actions/checkout@v2
uses: actions/checkout@v4

- name: Restore etags cache for certificate files
uses: actions/cache@v2
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/update-website.yml
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ jobs:
fi

- name: Checkout code
uses: actions/checkout@v2
uses: actions/checkout@v4
with:
ref: ${{ steps.base_branch.outputs.BRANCH }}

Expand Down Expand Up @@ -111,7 +111,7 @@ jobs:
fi

- name: Checkout code
uses: actions/checkout@v2
uses: actions/checkout@v4
with:
ref: gh-pages

Expand Down Expand Up @@ -183,7 +183,7 @@ jobs:

# Test that the site builds correctly.
- name: Checkout the newly created branch
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
ref: feature/auto-ghpages-update-${{ steps.get_pr_info.outputs.REF }}

Expand Down
10 changes: 10 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,14 @@
Changelog
=========

2.0.9
-----

### Overview of changes
- Hotfix: Rollback changes from PR [#657]. [#839] Props [@tomsommer][gh-tomsommer] & [@laszlof][gh-laszlof]

[#839]: https://github.com/WordPress/Requests/pull/839

2.0.8
-----

Expand Down Expand Up @@ -1015,6 +1023,7 @@ Initial release!
[gh-jrfnl]: https://github.com/jrfnl
[gh-KasperFranz]: https://github.com/KasperFranz
[gh-kwuerl]: https://github.com/kwuerl
[gh-laszlof]: https://github.com/laszlof
[gh-laurentmartelli]: https://github.com/laurentmartelli
[gh-mbabker]: https://github.com/mbabker
[gh-mircobabini]: https://github.com/mircobabini
Expand All @@ -1039,6 +1048,7 @@ Initial release!
[gh-TimothyBJacobs]: https://github.com/TimothyBJacobs
[gh-tnorthcutt]: https://github.com/tnorthcutt
[gh-todeveni]: https://github.com/todeveni
[gh-tomsommer]: https://github.com/tomsommer
[gh-tonebender]: https://github.com/tonebender
[gh-twdnhfr]: https://github.com/twdnhfr
[gh-TysonAndre]: https://github.com/TysonAndre
Expand Down
2 changes: 1 addition & 1 deletion src/Requests.php
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ class Requests {
*
* @var string
*/
const VERSION = '2.0.8';
const VERSION = '2.0.9';

/**
* Selected transport name
Expand Down
3 changes: 1 addition & 2 deletions src/Transport/Curl.php
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@
final class Curl implements Transport {
const CURL_7_10_5 = 0x070A05;
const CURL_7_16_2 = 0x071002;
const CURL_7_22_0 = 0x071600;

/**
* Raw HTTP data
Expand Down Expand Up @@ -364,7 +363,7 @@ private function setup_handle($url, $headers, $data, $options) {
$options['hooks']->dispatch('curl.before_request', [&$this->handle]);

// Force closing the connection for old versions of cURL (<7.22).
if ($this->version < self::CURL_7_22_0 && !isset($headers['Connection'])) {
if (!isset($headers['Connection'])) {
$headers['Connection'] = 'close';
}

Expand Down
Loading