Rollback changes from PR #657 #839
Conversation
| @@ -383,7 +382,7 @@ private function setup_handle($url, $headers, $data, $options) { | |||
| $options['hooks']->dispatch('curl.before_request', [&$this->handle]); | |||
|
|
|||
| // Force closing the connection for old versions of cURL (<7.22). | |||
There was a problem hiding this comment.
The comment was already present before we made the problematic change and was the reason why we used the specific version constraint we ended up with. Before we fully understand the context and where this was originally coming for, I'll prefer to keep in in there.
There was a problem hiding this comment.
The version number in the comment could be a cause for confusion going forward, just a heads up.
There was a problem hiding this comment.
Yes, indeed, and I think that's what has already happened in this case.
But I'm still assuming there is a reason why this was put in there initially. I'd like to understand this better before removing it.
There was a problem hiding this comment.
For future reference, this is the PR that introduced the comment: #211
This change rolls back a bug fix from PR #657. This PR contained no test's, and no real documentation what the issue was it was trying to solve. As a result, this change has broken updates (amongst other things) on at least anyone using curl 7.29.
See Issue #838 for more details.
Pull Request Type
This is a:
Context
Roll back a bug fix from PR #657.
Detailed Description
Quality assurance
Documentation
For new features:
examplesdirectory.docsdirectory.If the documentation is in a new markdown file, I have added a link to this new file to the Docs folder
README.mdfile.