Fsockopen: anticipate on PHP 8.4 deprecation of stream_context_set_option() overloaded signature
#822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ption()` overloaded signature PHP 8.4 will deprecate the two parameter signature of the `stream_context_set_option()` function. PHP 8.3 will introduce a replacement function `stream_context_set_options()` (take note of the `s` at the end!) for the two parameter signature. This commit adds a toggle to the `Fsockopen::request()` method to call the correct PHP function based on its availability. Refs: * https://wiki.php.net/rfc/deprecate_functions_with_overloaded_signatures#stream_context_set_option * https://www.php.net/stream_context_set_option * (docs for the new function are not yet available)
schlessera
approved these changes
Aug 14, 2023
|
Note: codecov not hitting the mark is expected as the PHP 8.3 build is not being uploaded to codecov (this will be changed once PHP 8.3 is released). |
schlessera
approved these changes
Sep 11, 2023
schlessera
deleted the
feature/fsockopen-php-83-84-stream_context_set_option
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHP 8.4 will deprecate the two parameter signature of the
stream_context_set_option()function.PHP 8.3 will introduce a replacement function
stream_context_set_options()(take note of thesat the end!) for the two parameter signature.This commit adds a toggle to the
Fsockopen::request()method to call the correct PHP function based on its availability.Refs: