Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support proxy in Requests::request_multiple() #667

Merged
merged 3 commits into from
Feb 28, 2022
Merged

Support proxy in Requests::request_multiple() #667

merged 3 commits into from
Feb 28, 2022

Conversation

simonhammes
Copy link
Contributor

@simonhammes simonhammes commented Jan 23, 2022 •
edited
Loading

Supersedes #292

Pull Request Type

  • I have checked there is no other PR open for the same change.

This is a:

  • Bug fix
  • New feature
  • Code quality improvement

Quality assurance

  • This change does NOT contain a breaking change (fix or feature that would cause existing functionality to change).
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added unit tests to accompany this PR.
  • The (new/existing) tests cover this PR 100%.
  • I have (manually) tested this code to the best of my abilities.
  • My code follows the style guidelines of this project.

@simonhammes simonhammes marked this pull request as ready for review January 23, 2022 16:46
@simonhammes
Copy link
Contributor Author

Please let me know in case I should add more tests :)

@simonhammes simonhammes changed the title Support proxy in Request::request_multiple() Support proxy in Requests::request_multiple() Jan 23, 2022
@simonhammes simonhammes mentioned this pull request Jan 23, 2022
Closed
12 tasks
@jrfnl jrfnl added this to the 2.1.0 milestone Feb 28, 2022
@jrfnl jrfnl merged commit ed5bdaa into WordPress:develop Feb 28, 2022
@jrfnl
Copy link
Member

jrfnl commented Feb 28, 2022

Confirmed that the tests fail without the patch and pass with the patch. Thanks @simonhammes for adding this test to the original patch!

@jrfnl jrfnl mentioned this pull request Feb 28, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schlessera schlessera schlessera approved these changes

Assignees
No one assigned
Labels
Component: Transports Type: bug
Projects
None yet
Milestone
2.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@simonhammes @jrfnl @schlessera