Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip alternate port test while portquiz has issues #640

Merged
merged 1 commit into from
Nov 24, 2021

Conversation

schlessera
Copy link
Member

Pull Request Type

  • I have checked there is no other PR open for the same change.

This is a:

  • Bug fix
  • New feature
  • Code quality improvement

Context

Skip alternate port test while required service has technical issues.

Detailed Description

The portquiz.net service that we are using to test the use of alternate ports is currently always returning 80 as the detected port, regardless of what port you actually did the request with.

We contacted the author via email to see if this is something that can be fixed.

In the mean time, this PR skips the particular test, as the failure is due to external circumstances.

An issue was opened to re-enable the test at a later point: #639

Quality assurance

  • This change does NOT contain a breaking change (fix or feature that would cause existing functionality to change).
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added unit tests to accompany this PR.
  • The (new/existing) tests cover this PR 100%.
  • I have (manually) tested this code to the best of my abilities.
  • My code follows the style guidelines of this project.

Documentation

For new features:

  • I have added a code example showing how to use this feature to the examples directory.
  • I have added documentation about this feature to the docs directory.
    If the documentation is in a new markdown file, I have added a link to this new file to the Docs folder README.md file.

@jrfnl jrfnl merged commit 9e7ab62 into develop Nov 24, 2021
@jrfnl jrfnl deleted the fix/skip-alternate-port-test branch November 24, 2021 12:45
jrfnl added a commit that referenced this pull request Nov 24, 2021
jrfnl added a commit that referenced this pull request Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants