Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename interface Hooker => HookManager #587

Merged
merged 1 commit into from
Nov 5, 2021
Merged

Conversation

schlessera
Copy link
Member

@schlessera schlessera commented Nov 5, 2021

Pull Request Type

  • I have checked there is no other PR open for the same change.

This is a:

  • Bug fix
  • New feature
  • Code quality improvement

Description

This PR renames the interface WpOrg\Requests\Hooker into WpOrg\Requests\HookManager. This change is done because the old name is not appropriate for an inclusive code base.

Quality assurance

  • This change does NOT contain a breaking change (fix or feature that would cause existing functionality to change).
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added unit tests to accompany this PR.
  • The (new/existing) tests cover this PR 100%.
  • I have (manually) tested this code to the best of my abilities.
  • My code follows the style guidelines of this project.

Documentation

For new features:

  • I have added a code example showing how to use this feature to the examples directory.
  • I have added documentation about this feature to the docs directory.
    If the documentation is in a new markdown file, I have added a link to this new file to the Docs folder README.md file.

Copy link
Member

@jrfnl jrfnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 I wholeheartedly agree with this change. Verified via a codebase search that the old name is no longer mentioned/referenced anywhere, except for in the upgrading.md file.

@jrfnl jrfnl merged commit 96f082a into develop Nov 5, 2021
@jrfnl jrfnl deleted the fix/rename-hook-manager branch November 5, 2021 13:15
@jrfnl jrfnl added this to the 2.0.0 milestone Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants