update cacert to the latest version #577
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Type
This is a:
Context
This PR updates
cacert.pem
following #571.When I failed with some requests today, I checked the code, finding that the reason is Let's Encrypt. Their old root CA expired last month and their new root CA ISRG Root X1 still contains the information this it was issued by the now-expired DST Root CA X3, this trusted path is checked (until the end of the chain) and then fails.
So it is of utter importance to remove it now and update a new patch as
1.8.2
.Also because this project uses its own cacert, we should update the cacert regularly.
This PR update cacert to a most recent version of it, released on 30 Sep, as #571 did not alter the date and hash and that is not recommended.
Quality assurance