Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update cacert to the latest version #577

Closed
wants to merge 1 commit into from

Conversation

ZsgsDesign
Copy link

Pull Request Type

  • I have checked there is no other PR open for the same change.

This is a:

  • Bug fix
  • New feature
  • Code quality improvement

Context

This PR updates cacert.pem following #571.

When I failed with some requests today, I checked the code, finding that the reason is Let's Encrypt. Their old root CA expired last month and their new root CA ISRG Root X1 still contains the information this it was issued by the now-expired DST Root CA X3, this trusted path is checked (until the end of the chain) and then fails.

So it is of utter importance to remove it now and update a new patch as 1.8.2.

Also because this project uses its own cacert, we should update the cacert regularly.

This PR update cacert to a most recent version of it, released on 30 Sep, as #571 did not alter the date and hash and that is not recommended.

Quality assurance

  • This change does NOT contain a breaking change (fix or feature that would cause existing functionality to change).
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added unit tests to accompany this PR.
  • The (new/existing) tests cover this PR 100%.
  • I have (manually) tested this code to the best of my abilities.
  • My code follows the style guidelines of this project.

@schlessera schlessera added this to the 2.0.0 milestone Nov 5, 2021
This was referenced Nov 15, 2021
@schlessera
Copy link
Member

Thanks for the PR, @ZsgsDesign !

We've opted for a fresh pull with no manual changes, and we'll be looking at automating this updating in the future via GHA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants