FilteredIteratorTest: improve tests #550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add docblocks to the test methods. * Add `@covers` tags. * Use more specific assertions. * Add the `$message` parameter to each assertion to allow for distinguishing which one failed more easily. * Use named data sets and indexed array items in the data provider.
jrfnl
changed the title
schlessera
approved these changes
Sep 23, 2021
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FilteredIteratorTest: improve the tests
@coverstags.$messageparameter to each assertion to allow for distinguishing which one failed more easily.FilteredIteratorTest: add @Covers tags
Note: this class could use some more tests, but at least what's there is now improved.
Related to #497