IdnaEncoderTest: improve tests #549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Reverted to draft as this PR needs PR #547 to be merged first. |
jrfnl
force-pushed
the
feature/idnaencoder-improve-tests
branch
from
fe68365
to
5145c8a
Compare
schlessera
requested changes
Sep 23, 2021
16 tasks
* Merge five tests doing the exact same thing, into one test using a data provider with named data sets and keyed data entries. * Remove `static` keyword from data provider. * Add docblock documentation to the test and the data provider.
This commit adds: * An empty text string test case. * A stringable object test case. * All other examples listed in the RFC as test cases.
* Merge five tests doing the exact same thing, into one test using a data provider with named data sets. * Add docblock documentation to the test and the data provider.
.... to improve readability.
jrfnl
force-pushed
the
feature/idnaencoder-improve-tests
branch
from
5145c8a
to
4f76f5b
Compare
|
Marking this as ready for review now PR #547 has been merged. |
schlessera
approved these changes
Oct 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IdnaEncoderTest: refactor encoding tests
statickeyword from data provider.IdnaEncoderTest: add additional valid encoding tests
This commit adds:
IdnaEncoderTest: refactor invalid encoding tests
IdnaEncoderTest: minor spacing tweaks
.... to improve readability.
IdnaEncoderTest: add @Covers tags
IdnaEncoder::to_ascii(): add select @codeCoverageIgnore annotation
Related to #497