InvalidArgument: add new create() method
#542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schlessera
requested changes
Sep 17, 2021
... to allow for standardizing the messages thrown via this Exception. Note: the `parent::__construct()` method is not overloaded with a `private` version, so variation is still possible, just not recommended. Includes adding a perfunctory unit test for the new method.
jrfnl
force-pushed
the
feature/invalidargumentexception-add-create-method
branch
from
b709233
to
30ad360
Compare
schlessera
approved these changes
Sep 17, 2021
schlessera
deleted the
feature/invalidargumentexception-add-create-method
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
InvalidArgument: add new create() method
... to allow for standardizing the messages thrown via this Exception.
Note: the
parent::__construct()method is not overloaded with aprivateversion, so variation is still possible, just not recommended.Includes adding a perfunctory unit test for the new method.
Transport classes: implement use of the new
InvalidArgument::create()method