Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FsockopenTest: add regression test for HTTP string #521

Merged
merged 1 commit into from
Sep 3, 2021

Commits on Aug 30, 2021

  1. FsockopenTest: add regression test for HTTP string

    PR 339 made a change to safeguard that the HTTP string would always contain a decimal point, never a comma.
    
    The original bug was related to the current locale influencing the results of the call to `sprintf()`.
    
    At the time, no test was added to safeguard the fix against regressions.
    
    This PR now adds this regression test.
    
    I've verified that without the fix as merged in 339, this test would fail.
    
    Includes adjusting the GH Actions workflows to install extra locales as otherwise the test would fail on the locale being changed to in the test not being available.
    jrfnl committed Aug 30, 2021
    Configuration menu
    Copy the full SHA
    9283115 View commit details
    Browse the repository at this point in the history