FsockopenTest: add regression test for HTTP string #520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR 339 made a change to safeguard that the HTTP string would always contain a decimal point, never a comma. The original bug was related to the current locale influencing the results of the call to `sprintf()`. At the time, no test was added to safeguard the fix against regressions. This PR now adds this regression test. I've verified that without the fix as merged in 339, this test would fail.
jrfnl
force-pushed
the
feature/472-add-http-version-string-test
branch
from
abc0fc1
to
9870f51
Compare
|
Closing for the time being while debugging why the locale change is not working on GHA. |
|
The locale change needed a tweak to the GH Actions workflows. Re-opening the PR now this has been fixed. |
|
Oh .. great.. can't reopen once there's been a force-push. Oh well. Opening a new PR instead in that case. See #521 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #339 made a change to safeguard that the HTTP string would always contain a decimal point, never a comma.
The original bug was related to the current locale influencing the results of the call to
sprintf().At the time, no test was added to safeguard the fix against regressions.
This PR now adds this regression test.
I've verified that without the fix as merged in #339, this test would fail.
Includes adjusting the GH Actions workflows to install extra locales as otherwise the test would fail on the locale being changed to in the test not being available.