Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: link review #489

Merged
merged 2 commits into from
Jun 18, 2021
Merged

Conversation

jrfnl
Copy link
Member

@jrfnl jrfnl commented Jun 12, 2021

Documentation: php.net link review

Reviewed all links, both in user facing documentation as well as in code documentation, for:

Fixes #480

Documentation: reviewed other links

... for correctness and use of https.

Note: this review explicitly did not change any URLs used in example code or in tests.

@jrfnl jrfnl added this to the 2.0.0 milestone Jun 12, 2021
@jrfnl jrfnl force-pushed the feature/480-docs-link-review branch 2 times, most recently from 235135d to 48e496b Compare June 18, 2021 10:07
@jrfnl jrfnl mentioned this pull request Jun 18, 2021
Reviewed all links, both in user facing documentation as well as in code documentation, for:
* Use of `https`
* Use of `www` (saves a redirect)
* Use of language agnostic permalinks as per https://www.php.net/urlhowto.php

Fixes 480
... for correctness and use of `https`.

Note: this review explicitly did not change any URLs used in example code or in tests.
@jrfnl jrfnl force-pushed the feature/480-docs-link-review branch from 48e496b to c8faa02 Compare June 18, 2021 10:11
@schlessera schlessera merged commit 0c427c8 into develop Jun 18, 2021
@schlessera schlessera deleted the feature/480-docs-link-review branch June 18, 2021 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation: verify links to php.net
2 participants