CodeCov: add configuration #464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit:
* Removes the configuration for the Coverall service which is no longer used.
* Adds a configuration for the CodeCov service.
This configuration:
- Adds a threshold of a 1% difference before failing the build for project status checks (= total coverage for the whole project).
Too often, due to some imprecision in how the code coverage is calculated, a difference of `-0.12%` (or similar) will be reported.
That kind of difference is no a reason to fail the build and block merges as it is often incorrect anyhow. (how can a docs PR cause a negative code coverage diff ?)
- Explicitly sets the path for which files we expect to be covered.
- For patch status checks the threshold remains at 0% (which is the default), meaning that the code coverage is not allowed to go down for the lines touched in the patch.
- Turns off in the inane PR comments. The status checks are sufficient, the huge comments on each PR do not add much value.
schlessera
approved these changes
Apr 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit:
This configuration:
Too often, due to some imprecision in how the code coverage is calculated, a difference of
-0.12%(or similar) will be reported.That kind of difference is no a reason to fail the build and block merges as it is often incorrect anyhow. (how can a docs PR cause a negative code coverage diff ?)