Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pagination to documentation pages #443

Merged
merged 3 commits into from
Mar 22, 2021

Conversation

JustinyAhin
Copy link
Member

Fixes #442.

Add pagination to documentation pages.

@codecov
Copy link

codecov bot commented Jan 15, 2021

Codecov Report

Merging #443 (f6c6d0b) into master (282d774) will decrease coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #443      +/-   ##
============================================
- Coverage     93.06%   92.95%   -0.12%     
- Complexity      763      764       +1     
============================================
  Files            21       21              
  Lines          1788     1788              
============================================
- Hits           1664     1662       -2     
- Misses          124      126       +2     
Impacted Files Coverage Δ Complexity Δ
library/Requests/Transport/fsockopen.php 93.78% <0.00%> (-0.57%) 69.00% <0.00%> (ø%)
library/Requests/Transport/cURL.php 94.23% <0.00%> (-0.49%) 67.00% <0.00%> (+1.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 282d774...f6c6d0b. Read the comment docs.

Copy link
Member

@jrfnl jrfnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Justin,

Sorry for the long wait before a review and thanks for your PR.

The markdown pages in the docs folder are also used for the https://requests.ryanmccue.info/docs/ website, so using absolute links to the markdown files in the GH repo is a no-no.

Could you please change the links to relative links ? I.e. just the filename.md.

@JustinyAhin
Copy link
Member Author

Thank you for looking Juliette.

I've updated the pagination to use relative links

Copy link
Member

@jrfnl jrfnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @JustinyAhin !

@jrfnl jrfnl merged commit 60926fa into WordPress:master Mar 22, 2021
@jrfnl jrfnl added this to the 1.8.0 milestone Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add pagination to the documentation
2 participants