-
Notifications
You must be signed in to change notification settings - Fork 501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
only decompress with proper content-encoding header #438
base: develop
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## master #438 +/- ##
============================================
- Coverage 93.12% 93.07% -0.05%
- Complexity 763 764 +1
============================================
Files 21 21
Lines 1788 1790 +2
============================================
+ Hits 1665 1666 +1
- Misses 123 124 +1
Continue to review full report at Codecov.
|
@jerrm Hiya! We're currently planning two triage sessions for Requests 2.0 and would like to invite you to join us in one or both of these sessions to talk us through the PR and discuss it. The triage sessions are currently planned for:
Would you be available to join us during those times on one of those days ? Also: would you be willing and able to add some tests for this change to the PR ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some notes:
- Needs rebase & conflict solving.
- The hard-coded array should become a class constant.
- Check needs to be done whether the array is complete for these purposes.
- Can this be done without using the performance-poor
array_intersect()
? - Needs tests.
Closes #437