Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update stats on PHP 5.2 usage as of March 2019 #334

Closed
wants to merge 1 commit into from
Closed

Update stats on PHP 5.2 usage as of March 2019 #334

wants to merge 1 commit into from

Conversation

tnorthcutt
Copy link
Contributor

No description provided.

ozh
ozh approved these changes Mar 1, 2019
View reviewed changes
Copy link
Collaborator

@ozh ozh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ozh
Copy link
Collaborator

ozh commented Mar 1, 2019

@rmccue tests failing because feelingrestful.com is down, any other humanmade option?

@jrfnl
Copy link
Member

jrfnl commented Sep 25, 2019

@tnorthcutt I'd like to merge this in. Would you mind updating it with the latest % (1.5%) and rebasing the PR so it becomes mergable ?

If you don't want to or don't have the time, please let me know.

@tnorthcutt
Copy link
Contributor Author

@jrfnl I would love to, but I both don't have time right now, and I think I'm not clear on the numbers at this point. WP Stats shows 1.5% on PHP 5.2, but that doesn't really make sense if the number was recently 60%...

I'd prefer to leave this to someone else. Thanks for the ping.

@tnorthcutt tnorthcutt closed this Sep 25, 2019
@jrfnl
Copy link
Member

jrfnl commented Sep 25, 2019

I would love to, but I both don't have time right now, and I think I'm not clear on the numbers at this point. WP Stats shows 1.5% on PHP 5.2, but that doesn't really make sense if the number was recently 60%...

If I remember correctly, the colors for PHP 5.2 and PHP 5.6 at some point were the same and caused confusion. PHP 5.6 at the time was at 60%. (seen this issue elsewhere as well).

@jrfnl jrfnl mentioned this pull request Sep 25, 2019
Merged
@jrfnl
Copy link
Member

jrfnl commented Sep 25, 2019

New PR with props created - see #367

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ozh ozh ozh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tnorthcutt @ozh @jrfnl