-
Notifications
You must be signed in to change notification settings - Fork 498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a .gitattributes file #328
Conversation
This is added to keep the file size when using composer down
@rmccue any chance this can get implemented? |
@KasperFranz Apologies for the delay here. Happy to merge in; could you merge master into your branch so tests pass please? |
@KasperFranz It appears you've rebased here, as the commits now appear as committed by you but authored by someone else. Could you correct this please? |
It was a quick test, while not being at my machine at home I will do that later today |
No rush, this repo moves fairly slowly :) |
Codecov Report
@@ Coverage Diff @@
## master #328 +/- ##
=========================================
Coverage 92.11% 92.11%
Complexity 760 760
=========================================
Files 21 21
Lines 1762 1762
=========================================
Hits 1623 1623
Misses 139 139 Continue to review full report at Codecov.
|
491a283
to
b434dad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only thing I'm wondering about is the ignore
for the docs
and the examples
.
All the rest isn't needed for someone new to the repo to implement it, but those can be useful for a first time implementation (similar to the readme).
I'm in favor of ignoring those. I would even remove all non php files, in particular all the .MD files that are much less readable on a server than on Github. The idea is that when using the library as is on a prod server, you don't end up with files that can be used for full path disclosure |
My thoughts were that when you are using this (or any other package), I would typically look through the code and the documentation online instead of reading through a docs folder in the vendor directory. This was partly made to start a discussion about it as well, I am glad to make changes to the code if anyone wants me to change anything. The branch is also up to date now. |
The way the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, I'm 👍 on excluding the docs; agreed on using the website instead.
This is added to keep the file size when using composer down