Fix/Rationalize transports (v2) #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: library/Requests/Transport/cURL.php library/Requests/Transport/fsockopen.php
TRACE requests "MUST NOT [have] a message body" per RFC7231/HTTP 1.1, so there's no need for the parameter.
This was referenced Oct 26, 2015
rmccue
added a commit
that referenced
this pull request
Oct 26, 2015
Fix/Rationalize transports (v2)
| case Requests::HEAD: | ||
| curl_setopt($this->handle, CURLOPT_CUSTOMREQUEST, $options['type']); | ||
| curl_setopt($this->handle, CURLOPT_NOBODY, true); |
There was a problem hiding this comment.
@egeloen Looks like CURLOPT_POSTFIELDS doesn't get set for HEAD requests; was this intentional?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following on from @egeloen's fantastic work in #143, this merges master in and corrects some small issues.
Fixes #137, fixes #91.