Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PATCH method support #2

Closed
rmccue opened this issue Feb 7, 2012 · 3 comments
Closed

Add PATCH method support #2

rmccue opened this issue Feb 7, 2012 · 3 comments
Assignees
@rmccue
Labels
Type: testing/chores/QA
Milestone
1.6

Comments

@rmccue
Copy link
Collaborator

rmccue commented Feb 7, 2012

No description provided.

@ghost ghost assigned rmccue Feb 7, 2012
@rmccue
Copy link
Collaborator Author

rmccue commented Feb 8, 2012

See RFC5789 for details.

rmccue added a commit that referenced this issue Feb 8, 2012
@rmccue
Add PATCH support. See #2, still awaiting tests.
48dc511 
Unable to add tests at the moment, as httpbin's /patch endpoint is broken and refuses to accept PATCH requests
@rmccue
Copy link
Collaborator Author

rmccue commented Feb 8, 2012

See kennethreitz/httpbin#33

@rmccue
Copy link
Collaborator Author

rmccue commented Aug 10, 2013

Fixed in 062a17e

@rmccue rmccue closed this as completed Aug 10, 2013
@adam-pro adam-pro mentioned this issue Apr 24, 2015
Open
@sriducati sriducati mentioned this issue Aug 26, 2016
Open
@dineshmo dineshmo mentioned this issue Sep 21, 2017
Closed
@AllegroBarry AllegroBarry mentioned this issue Nov 9, 2017
Closed
jrfnl added a commit that referenced this issue Jun 21, 2021
@jrfnl
PHP 8.1: fix deprecation notices in Requests_Transport_cURL
ba05144 
The `Requests_Transport_cURL:;setup_handle()` and `Requests_Transport_cURL::format_get()` methods, both call the PHP native `http_build_query()` function.
The second parameter of which is the _optional_ `$numeric_prefix` parameter which expects a `string`.

A parameter being optional, however, does not automatically make it nullable.

As of PHP 8.1, passing `null` to a non-nullable PHP native function will generate a deprecation notice.
In this case, both these function calls yielded a `http_build_query(): Passing null to parameter #2 ($numeric_prefix) of type string is deprecated` notice.

Changing the `null` to an empty string fixes this without BC-break.

This change is already covered by tests as 15 of the existing tests failed on these function calls when running the tests on PHP 8.1.

Refs:
* https://www.php.net/manual/en/function.http-build-query.php
* https://wiki.php.net/rfc/deprecate_null_to_scalar_internal_arg
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rmccue rmccue

Labels
Type: testing/chores/QA
Projects
None yet
Milestone
1.6
Development

No branches or pull requests
1 participant
@rmccue