Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed header nav menu design #1366

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

aezazs-multidots
Copy link

I have fixed the design issue in the header navigation menu, which was coming in at a screen size below 783 pixel.

Below is a screenshot.

CleanShot 2023-02-22 at 13 24 43@2x

Closes #1365

@jonathanbossenger jonathanbossenger added the [Dev] Needs Review Pull request needing a review. label Mar 28, 2023
@jonathanbossenger
Copy link
Collaborator

@adamwoodnz this is another case similar to #1362

@jonathanbossenger
Copy link
Collaborator

In a recent commit, we fixed the issue where certain files were causing conflicts that were blocking successful pull requests.

This commit adds the following files to .gitignore, and ensures the conflicts don't happen any more.

/wp-content/themes/pub/wporg-learn-2020/css/print.css
/wp-content/themes/pub/wporg-learn-2020/css/style-rtl.css
/wp-content/themes/pub/wporg-learn-2020/css/style.css

Could you please either refresh your branch to use the most recent version of trunk branch OR delete and recreate this PR based on the most recent trunk branch, so that these conflicts will no longer be a problem

@jonathanbossenger jonathanbossenger added [Dev] Needs Refresh Pull request needing a refresh. and removed [Dev] Needs Review Pull request needing a review. labels Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Dev] Needs Refresh Pull request needing a refresh.
Projects
Status: In Review (PRs only)
Development

Successfully merging this pull request may close these issues.

In 768-pixel screen size, the header menu design breaks.
2 participants