Skip to content

Commit

Permalink
UX: Multichain: Add separator under 'View on Explorer' (MetaMask#21223)
Browse files Browse the repository at this point in the history
## **Description**
This PR adds a separator to the Multichain global menu under View on
Explorer

## **Manual testing steps**

1.  Open the Global Menu
2. See the separator between View on Explorer and its next menu item

## **Screenshots/Recordings**

<img width="290" alt="SCR-20231005-txgc"
src="https://github.com/MetaMask/metamask-extension/assets/46655/5e8dbbd5-45dc-4eda-999a-117580569190">


## **Related issues**

Fixes: MetaMask#21220

This issue also references the position of the Account Picker but that
is addressed in
MetaMask#21220

## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've clearly explained:
  - [ ] What problem this PR is solving.
  - [ ] How this problem was solved.
  - [ ] How reviewers can test my changes.
- [ ] I’ve indicated what issue this PR is linked to: Fixes #???
- [ ] I’ve included tests if applicable.
- [ ] I’ve documented any added code.
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
- [ ] I’ve properly set the pull request status:
  - [ ] In case it's not yet "ready for review", I've set it to "draft".
- [ ] In case it's "ready for review", I've changed it from "draft" to
"non-draft".

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
  • Loading branch information
darkwing authored Oct 10, 2023
1 parent f80569a commit a6f058f
Showing 1 changed file with 8 additions and 0 deletions.
8 changes: 8 additions & 0 deletions ui/components/multichain/global-menu/global-menu.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import {
import { lockMetamask } from '../../../store/actions';
import { useI18nContext } from '../../../hooks/useI18nContext';
import {
Box,
IconName,
///: BEGIN:ONLY_INCLUDE_IN(snaps)
Text,
Expand Down Expand Up @@ -54,6 +55,8 @@ import {
import {
AlignItems,
BackgroundColor,
BlockSize,
BorderColor,
Display,
JustifyContent,
TextAlign,
Expand Down Expand Up @@ -109,6 +112,11 @@ export const GlobalMenu = ({ closeMenu, anchorElement }) => {
closeMenu={closeMenu}
address={address}
/>
<Box
borderColor={BorderColor.borderMuted}
width={BlockSize.Full}
style={{ height: '1px', borderBottomWidth: 0 }}
></Box>
<MenuItem
iconName={IconName.Connect}
disabled={hasUnapprovedTransactions}
Expand Down

0 comments on commit a6f058f

Please sign in to comment.