Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ship names - proof of concept #203

Merged
merged 2 commits into from
Nov 5, 2019

Conversation

sgerhardt
Copy link
Contributor

@sgerhardt sgerhardt commented Nov 3, 2019

Problem:

#199 Ship and fleet names aren't appearing. It appears this is due to not updating tags that were introduced in the man the guns dlc.
image
image

Solution:

Update tags. In the image below, you'll see that the fleet name appears, and that the ships show as a fleet and task force in the navy sidebar.
image

image

This small batch of changes is just a proof of concept. Updating ALL the ships will obviously be a fairly involved process and a huge diff. Wanted to make sure @Wolferos is cool with this first.

Testing:

Load the mod as Germany in 1910, and verify the ships located in Wilhelmshaven have their names updated are in the Hochseeflotte.

@Wolferos
Copy link
Owner

Wolferos commented Nov 5, 2019

Hey!

Thanks @sgerhardt for the PR! We've tested it and it works well.

This small batch of changes is just a proof of concept. Updating ALL the ships will obviously be a fairly involved process and a huge diff

It's one of those long and tedious process that comes sometimes with DLC and updates (we had to do many refactoring for political parties, OOB, Scripts, Events, etc.)

@Wolferos Wolferos merged commit f988f5d into Wolferos:develop Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants