try to fix leak in #187 #196
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
tests seem fine in my end @AyanSinhaMahapatra , could you please confirm and merge (and hopefuly release! :D) if everything looks fine in your end? Many thanks! |
|
Thanks @eloyfelix let me test locally and then merge and release 😊 Thanks++ for this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
building up on commits from #187. This should fix the memory leak in #187 that fixes iter_long missing some logest matches.
Not really experienced on this stuff. Slowly checking with Valgrind on my end but any help would be appreciated!
I get:
tests/test_issue_9.py::MemoryUsageDoesNotGrow::test_memory_usage_does_not_grow PASSED@AyanSinhaMahapatraWhich seemed to be the issue as reported in here: #185 (comment)