Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

complete the service configuration #423

Merged
merged 2 commits into from
Jan 9, 2024
Merged

complete the service configuration #423

merged 2 commits into from
Jan 9, 2024

Conversation

frezes
Copy link
Collaborator

@frezes frezes commented Jan 9, 2024 •
edited
Loading

  1. 在 ServiceSpec 将包含 QuerySpec、 RouterSpec 等组件配置
  2. 将 CommonSpec 的 Containers 字段定义由 []corev1.Container 改为 runtime.RawObject, 避免 CRD 大小超限
  3. 升级依赖

@frezes frezes requested a review from junotx January 9, 2024 09:55
@frezes
Copy link
Collaborator Author

frezes commented Jan 9, 2024

关联 #424

@frezes frezes requested review from benjaminhuo and wanjunlei and removed request for junotx and benjaminhuo January 9, 2024 10:23
@frezes
Copy link
Collaborator Author

frezes commented Jan 9, 2024

/cc @junotx @wanjunlei

benjaminhuo
benjaminhuo reviewed Jan 9, 2024
View reviewed changes
pkg/api/monitoring/v1alpha1/service_types.go
}

type CompactorTemplateSpec struct {
CompactorSpec `json:",inline"`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
Transferred to CompactorTemplateSpec? Cannot find it here

Copy link
Collaborator Author

@frezes frezes Jan 9, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

在 CompactorSpec 中已添加

@frezes
Copy link
Collaborator Author

frezes commented Jan 9, 2024

crd 更新需要执行 kubectl apply --server-side --force-conflicts -f config/crd/bases/

@benjaminhuo benjaminhuo merged commit bf61862 into WizTelemetry:master Jan 9, 2024
@frezes frezes mentioned this pull request Jan 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjaminhuo benjaminhuo benjaminhuo approved these changes

@wanjunlei wanjunlei Awaiting requested review from wanjunlei

Assignees

@benjaminhuo benjaminhuo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@frezes @benjaminhuo