Sort defines alphabetically #878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When modifying the defines, this makes it less likely to accidentally add a define twice. This also includes a fix for the documentation patching, which previously ignored the HAVE_* variables and duplicated them on every call to `download.sh`.
mceachen
approved these changes
Sep 16, 2022
fulldecent
approved these changes
Oct 26, 2022
JoshuaWise
approved these changes
Nov 21, 2022
B4nan
referenced
this pull request
in mikro-orm/mikro-orm
Nov 28, 2022
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [better-sqlite3](https://togithub.com/WiseLibs/better-sqlite3) | [`^7.0.0` -> `^8.0.0`](https://renovatebot.com/diffs/npm/better-sqlite3/7.6.2/8.0.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [better-sqlite3](https://togithub.com/WiseLibs/better-sqlite3) | [`7.6.2` -> `8.0.0`](https://renovatebot.com/diffs/npm/better-sqlite3/7.6.2/8.0.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>WiseLibs/better-sqlite3</summary> ### [`v8.0.0`](https://togithub.com/WiseLibs/better-sqlite3/releases/tag/v8.0.0) [Compare Source](https://togithub.com/WiseLibs/better-sqlite3/compare/v7.6.2...v8.0.0) #### Breaking Changes - Dropped support for Node.js versions `10.x` and `12.x`. #### Non-breaking Changes - Upgraded to SQLite version `3.40.0`. - Fixed LIMIT and OFFSET queries on virtual tables, by [@​mandel59](https://togithub.com/mandel59) in [https://github.com/WiseLibs/better-sqlite3/pull/873](https://togithub.com/WiseLibs/better-sqlite3/pull/873) - Fixed various compilation issues: - By [@​nathanhammond](https://togithub.com/nathanhammond) in [https://github.com/WiseLibs/better-sqlite3/pull/894](https://togithub.com/WiseLibs/better-sqlite3/pull/894) - By [@​neoxpert](https://togithub.com/neoxpert) in [https://github.com/WiseLibs/better-sqlite3/pull/870](https://togithub.com/WiseLibs/better-sqlite3/pull/870) #### New Contributors - [@​mandel59](https://togithub.com/mandel59) made their first contribution in [https://github.com/WiseLibs/better-sqlite3/pull/873](https://togithub.com/WiseLibs/better-sqlite3/pull/873) - [@​nathanhammond](https://togithub.com/nathanhammond) made their first contribution in [https://github.com/WiseLibs/better-sqlite3/pull/894](https://togithub.com/WiseLibs/better-sqlite3/pull/894) - [@​neoxpert](https://togithub.com/neoxpert) made their first contribution in [https://github.com/WiseLibs/better-sqlite3/pull/870](https://togithub.com/WiseLibs/better-sqlite3/pull/870) - [@​threema-danilo](https://togithub.com/threema-danilo) made their first contribution in [https://github.com/WiseLibs/better-sqlite3/pull/878](https://togithub.com/WiseLibs/better-sqlite3/pull/878) **Full Changelog**: WiseLibs/better-sqlite3@v7.6.2...v8.0.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "every weekday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/mikro-orm/mikro-orm). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4yOS4yIiwidXBkYXRlZEluVmVyIjoiMzQuMzcuMCJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When modifying the defines, this makes it less likely to accidentally add a define twice.
This also includes a fix for the documentation patching, which previously ignored the HAVE_* variables and duplicated them on every call to
download.sh.(The context for this change is that I have a set of patches that needs to be kept up to date for new releases of better-sqlite3. Sorted defines result in a smaller diff and easier maintenance.)