Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Node v18 prebuilds #800

Merged
merged 1 commit into from
May 13, 2022
Merged

Add support for Node v18 prebuilds #800

merged 1 commit into from
May 13, 2022

Conversation

m4heshd
Copy link
Contributor

@m4heshd m4heshd commented May 1, 2022 •
edited
Loading

Notes:

  • Ubuntu image for tests has been changed to ubuntu-20.04 since Node v18 requires GLIBC 2.28

Thoughts:

@m4heshd m4heshd mentioned this pull request May 1, 2022
Closed
mceachen
mceachen approved these changes May 1, 2022
View reviewed changes
Copy link
Member

@mceachen mceachen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the update!

@Prinzhorn Prinzhorn mentioned this pull request May 3, 2022
Closed
@mceachen mceachen merged commit e886811 into WiseLibs:master May 13, 2022
danielbeardsley added a commit to iFixit/react-commerce that referenced this pull request Jul 7, 2023
@danielbeardsley
better-sqlite3: upgrade to support node-18 pre-built binaries
8340c1c 
WiseLibs/better-sqlite3#800
@whizbangpop whizbangpop mentioned this pull request May 25, 2024
Open
This was referenced Sep 14, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mceachen mceachen mceachen approved these changes

@JoshuaWise JoshuaWise Awaiting requested review from JoshuaWise JoshuaWise is a code owner

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@m4heshd @mceachen