Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add armv7 prebuilds #756

Closed
wants to merge 1 commit into from

Conversation

tkurki
Copy link

@tkurki tkurki commented Jan 29, 2022

Use qemu and --platform linux/arm/v7 to cross build
binaries for 32 bit arm v7.

Based on #714, see also #601.

Untested, but a slimmed down version seems to build ok.

Use qemu and --platform linux/arm/v7 to cross build
binaries for 32 bit arm v7.
@m4heshd
Copy link
Contributor

m4heshd commented Feb 1, 2022

This is a much needed feature and a good approach but there seem to be some issues.

  1. This build will fail because you're missing a necessary quotation mark and a new line at the end of the new job
  2. It's unnecessary to add a completely new job for this specific build when you can simply use a build matrix

This is implemented in a much cleaner way in #758 since that was already been done for a fork.

@tkurki
Copy link
Author

tkurki commented Feb 1, 2022

Oooh so much better - all hail #758 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants