Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing #45 pinModeAlt mode is checked in wrong ints #46

Merged
merged 1 commit into from
Sep 22, 2016
Merged

Fixing #45 pinModeAlt mode is checked in wrong ints #46

merged 1 commit into from
Sep 22, 2016

Conversation

NoHomey
Copy link
Collaborator

@NoHomey NoHomey commented Sep 21, 2016

pinModeAlt mode should be in (FSEL_INPT, FSEL_OUTP, FSEL_ALT0, FSEL_ALT1, FSEL_ALT2, FSEL_ALT3, FSEL_ALT4, FSEL_ALT5) not in (WPI_MODE_PINS, WPI_MODE_PHYS, WPI_MODE_GPIO).

@NoHomey
fixing pinModeAlt mode
24b0908 
pinModeAlt mode should be in FSEL_INPT, FSEL_OUTP, FSEL_ALT0, FSEL_ALT1, FSEL_ALT2, FSEL_ALT3, FSEL_ALT4, FSEL_ALT5 not in WPI_MODE_PINS, WPI_MODE_PHYS, WPI_MODE_GPIO.
@NoHomey
Copy link
Collaborator Author

NoHomey commented Sep 21, 2016

Also found that #24 has been closed with defining and exporting FSEL_INPT, FSEL_OUTP, FSEL_ALT0, FSEL_ALT1, FSEL_ALT2, FSEL_ALT3, FSEL_ALT4, FSEL_ALT5 in a186b9c but pinModeAlt implementation has not changed in that commit.

@NoHomey
Copy link
Collaborator Author

NoHomey commented Sep 21, 2016

@nekuz0r could you review this pull request?

@nekuz0r nekuz0r merged commit 5bea401 into WiringPi:master Sep 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nekuz0r nekuz0r nekuz0r approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NoHomey @nekuz0r