Add resize handlers to sides of widgets #394
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luksurious
commented
Mar 28, 2019
| @@ -145,6 +145,7 @@ | |||
| dragboardCover.style.top = "0"; | |||
| dragboardCover.style.left = "0"; | |||
| dragboardCover.style.width = "100%"; | |||
| dragboardCover.style.cursor = handleElement.dataset.cursor; | |||
There was a problem hiding this comment.
To keep the cursor when resizing, I need a way to pass the cursor type to the cover. This solution might not be the cleanest but I found that better than passing it through 3 levels
luksurious
commented
Mar 28, 2019
| right: 34px; | ||
| cursor: s-resize; | ||
| } | ||
| .wc-widget { |
There was a problem hiding this comment.
just nested the resize elements
luksurious
commented
Mar 28, 2019
| cursor: se-resize; | ||
| } | ||
|
|
||
| .wc-right-side-resize-handle { |
There was a problem hiding this comment.
and new styles for the side handlers
luksurious
commented
Mar 28, 2019
| @@ -2,6 +2,7 @@ | |||
| <div class="fade panel panel-default"> | |||
| <div class="wc-widget-heading panel-heading"><h4 class="panel-title"><t:title/></h4><div class="wc-widget-infobuttons"><t:errorbutton/></div><div class="wc-widget-buttons"><t:minimizebutton/><t:menubutton/><t:closebutton/></div></div> | |||
| <div class="wc-widget-body"><t:iframe/></div> | |||
| <t:leftsideresizehandle/><t:rightsideresizehandle/> | |||
There was a problem hiding this comment.
I put them outside the body because the body has overflow: hidden so the 6px outside would not work. This seems to work pretty well
luksurious
commented
Mar 28, 2019
| @@ -93,7 +93,6 @@ | |||
| } | |||
|
|
|||
| .wc-widget-footer { | |||
| height: 3px; | |||
There was a problem hiding this comment.
From what I can see this is not necessary and only creates a white border at the bottom
2 similar comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature to allow widgets to be resized from the sides as well.