Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made changes to accommodate breaking change in testcontainers-dotnet 3.9 #1127

Conversation

epDugas
Copy link
Contributor

@epDugas epDugas commented Jun 26, 2024

Made changes to accommodate breaking change in testcontainers-dotnet 3.9

3.9.0
1146
1100

@StefH StefH added the feature label Jun 26, 2024
@StefH
Copy link
Collaborator

StefH commented Jun 26, 2024

Made changes to accommodate breaking change in testcontainers-dotnet 3.9

Ref: testcontainers/testcontainers-dotnet#1100

Is this for sure a breaking change?

@epDugas
Copy link
Contributor Author

epDugas commented Jun 26, 2024

Made changes to accommodate breaking change in testcontainers-dotnet 3.9
Ref: testcontainers/testcontainers-dotnet#1100

Is this for sure a breaking change?

Yes, added relevant urls to pr description.

@StefH
Copy link
Collaborator

StefH commented Jun 26, 2024

Ok. Thanks for the heads-up.

This is not the first time they introduce a breaking change in a minor version.

Is there a better way to handle this? Or is it only feasible to fix it like this PR?

@epDugas
Copy link
Contributor Author

epDugas commented Jun 26, 2024

Ok. Thanks for the heads-up.

This is not the first time they introduce a breaking change in a minor version.

Is there a better way to handle this? Or is it only feasible to fix it like this PR?

Yeah, I saw you had to pin to 3.7.
There may be a better way, but I didn't see an obvious one. I just made the change match the changes that were made to all of the included ContainerBuilders.

@StefH StefH merged commit bf28ba7 into WireMock-Net:master Jun 26, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants