Define assembler files for ARM64 + Windows + GCC combination #1
+14
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eukarpov
reviewed
Nov 8, 2024
| alias asm_sources | ||
| : asm/make_arm64_aapcs_pe_armclang.asm | ||
| asm/jump_arm64_aapcs_pe_armclang.asm |
There was a problem hiding this comment.
It looks like it was not defined here correctly initially for clang and this change fixes it.
eukarpov
approved these changes
Nov 8, 2024
|
Thanks for the reviews! PR into upstream was opened boostorg#275, so I'm closing this PR as it was just for internal review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that Clang on Aarch64 uses the same syntax as GNU (boostorg#262), so at the end it was enough to just use the same assembler files.
@Blackhex @eukarpov please take a brief look at the assembler files:
https://github.com/Windows-on-ARM-Experiments/boost-context/blob/develop/src/asm/jump_arm64_aapcs_pe_armclang.S
https://github.com/Windows-on-ARM-Experiments/boost-context/blob/develop/src/asm/make_arm64_aapcs_pe_armclang.S
https://github.com/Windows-on-ARM-Experiments/boost-context/blob/develop/src/asm/ontop_arm64_aapcs_pe_armclang.S
if you'll see something that should not work with our toolchain. But I think all should be alright since they're compiled and they're the same as the ones for Clang.