Skip to content

Commit

Permalink
Fix styled-components performance
Browse files Browse the repository at this point in the history
- Styled Components types were not playing well with TypeScript 3.4. Downgrading to 3.3.3333 until it is fixed in 3.5. microsoft/TypeScript#30663
  • Loading branch information
WilsonCWong committed May 9, 2019
1 parent c0af659 commit 46538b3
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 10 deletions.
6 changes: 3 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,6 @@
"version": "0.1.0",
"private": true,
"dependencies": {
"@types/animejs": "^2.0.2",
"@types/styled-components": "^4.1.14",
"animejs": "^3.0.1",
"react": "^16.8.6",
"react-dom": "^16.8.6",
Expand All @@ -31,13 +29,15 @@
"@babel/plugin-proposal-class-properties": "^7.4.0",
"@babel/plugin-proposal-object-rest-spread": "^7.4.3",
"@babel/preset-typescript": "^7.3.3",
"@types/animejs": "^2.0.2",
"@types/jest": "^24.0.11",
"@types/node": "^11.13.5",
"@types/react-dom": "^16.8.4",
"@types/styled-components": "^4.1.14",
"babel-plugin-styled-components": "^1.10.0",
"customize-cra": "^0.2.12",
"jest-styled-components": "^6.3.1",
"react-app-rewired": "^2.1.1",
"typescript": "^3.4.4"
"typescript": "3.3.3333"
}
}
14 changes: 7 additions & 7 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -1171,9 +1171,9 @@
"@types/react" "*"

"@types/react-native@*":
version "0.57.51"
resolved "https://registry.yarnpkg.com/@types/react-native/-/react-native-0.57.51.tgz#adcb02141734b72822848351be734971e508f5f1"
integrity sha512-0LkXPeV1Hn+5zZ0BE6RBrBJTpM2P4S+306H9lKdi220PHFwMtHt1k8SiQpqUA2yjpi+c6pFIq6H2zZGusPHT9w==
version "0.57.53"
resolved "https://registry.yarnpkg.com/@types/react-native/-/react-native-0.57.53.tgz#f54a1886c8de1bf4b54bd5f463d5d2e7cf3a7634"
integrity sha512-dBcehLQmES4gQxZAd4XifbaQA9cTtFIjDsIcYRIy2SG6aoQsqQjZmC2a/Nv2orvG8qR9pLgoO3GlJS2/lj5jAA==
dependencies:
"@types/prop-types" "*"
"@types/react" "*"
Expand Down Expand Up @@ -9694,10 +9694,10 @@ typedarray@^0.0.6:
resolved "https://registry.yarnpkg.com/typedarray/-/typedarray-0.0.6.tgz#867ac74e3864187b1d3d47d996a78ec5c8830777"
integrity sha1-hnrHTjhkGHsdPUfZlqeOxciDB3c=

typescript@^3.4.4:
version "3.4.4"
resolved "https://registry.yarnpkg.com/typescript/-/typescript-3.4.4.tgz#aac4a08abecab8091a75f10842ffa0631818f785"
integrity sha512-xt5RsIRCEaf6+j9AyOBgvVuAec0i92rgCaS3S+UVf5Z/vF2Hvtsw08wtUTJqp4djwznoAgjSxeCcU4r+CcDBJA==
typescript@3.3.3333:
version "3.3.3333"
resolved "https://registry.yarnpkg.com/typescript/-/typescript-3.3.3333.tgz#171b2c5af66c59e9431199117a3bcadc66fdcfd6"
integrity sha512-JjSKsAfuHBE/fB2oZ8NxtRTk5iGcg6hkYXMnZ3Wc+b2RSqejEqTaem11mHASMnFilHrax3sLK0GDzcJrekZYLw==

[email protected], uglify-js@^3.1.4:
version "3.4.9"
Expand Down

0 comments on commit 46538b3

Please sign in to comment.