Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Framework Upped to 4.8 fixes the TLS issue the client is having? #43

Merged
merged 5 commits into from
Jan 21, 2021
Merged

Conversation

M1XT3NZ
Copy link
Contributor

@M1XT3NZ M1XT3NZ commented Jan 18, 2021

tbh I have no clue why an older version also fixes this but it seems this also does the trick?
also, a newer framework version doesn't hurt.

For me this issue seems to be fixed.
#41 #42 fixes those two problems cause they are the same.

WilliamRagstad and others added 5 commits December 17, 2019 18:37
Fixed som fonts not installing
Added search functionality and fixed some common problems
New local folder and autofocus to active font.
@WilliamRagstad
Copy link
Owner

The problem with #41 and #42 is a failed check for an invalid input in the checkForUpdates method. I do not know why this would fix the problem but seems like a good idea to update the framework if compatible anyways.

@M1XT3NZ
Copy link
Contributor Author

M1XT3NZ commented Jan 20, 2021

seemed weird for me too,
the invalid input comes because the webrequest returns null
Since the TLS check fails. (Can't get a secure connection for whatever reason)
which then crashes the program (could've also added a check for the potential null but seems to work like this soo?)

@WilliamRagstad WilliamRagstad merged commit 3778e3f into WilliamRagstad:master Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants