fix: visualize diffs of PlantUML descriptions which include both renaming and changes #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exKAZUu
reviewed
Oct 30, 2019
src/finder/GitHubFinder.ts
Outdated
| console.log(filePaths); | ||
| if (filePaths.length == 1) return [filePaths[0], filePaths[0]]; | ||
| if (filePaths.length == 2) return [filePaths[0], filePaths[1]]; | ||
| else return ['', '']; |
exKAZUu
reviewed
Oct 30, 2019
src/finder/GitHubFinder.ts
Outdated
| filePath += separator; | ||
| } | ||
| } | ||
| console.log(filePaths); |
There was a problem hiding this comment.
Could you remove this debug code?
exKAZUu
reviewed
Oct 30, 2019
| @@ -74,9 +74,9 @@ export class GitHubPullRequestDiffFinder implements DiffFinder { | |||
| return diffs; | |||
| } | |||
|
|
|||
| private getBaseHeadBranchNames($root: JQuery<Node>): string[] { | |||
| private getBaseHeadBranchNames($root: JQuery<Node>): [string, string] { | |||
exKAZUu
reviewed
Oct 30, 2019
| const tableObjectTagName = 'div.TableObject-item.TableObject-item--primary'; | ||
| const getTagName = (baseOrHead: string): string => | ||
| const getTagName = (baseOrHead: 'base' | 'head'): string => |
exKAZUu
requested changes
Oct 30, 2019
added 2 commits
October 30, 2019 13:53
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #156
will support #105 #106 #266