Throw an exception instead of returning a null value

WildernessLabs · Aug 2, 2023 · 81f19b7 · 81f19b7
1 parent 6c086c9
commit 81f19b7
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 8 deletions.
diff --git a/source/Meadow.Core/NetworkAdapterBase.cs b/source/Meadow.Core/NetworkAdapterBase.cs
@@ -19,12 +19,10 @@ public event NetworkConnectionHandler NetworkConnected
     {
         add
         {
-            Resolver.Log.Info($"subscribe to NetworkConnected on {this.GetType().Name}");
             _connected += value;
         }
         remove
         {
-            Resolver.Log.Info($"unsubscribe to NetworkConnected on {this.GetType().Name}");
             _connected -= value;
         }
     }

diff --git a/source/implementations/f7/Meadow.F7/Devices/F7CellNetworkAdapter.cs b/source/implementations/f7/Meadow.F7/Devices/F7CellNetworkAdapter.cs
@@ -200,11 +200,6 @@ public string AtCmdsOutput
     public List <CellNetwork> Scan()
     {
         scannedCellNetworks = Core.Interop.Nuttx.MeadowCellNetworkScanner();
-
-        if (scannedCellNetworks == null)
-        {
-            Resolver.Log.Error("No available networks found, please ensure that your device is in scanning mode.");
-        }
 
         return scannedCellNetworks;
     }

diff --git a/source/implementations/f7/Meadow.F7/Interop/Interop.cell.cs b/source/implementations/f7/Meadow.F7/Interop/Interop.cell.cs
@@ -123,7 +123,7 @@ private static List<CellNetwork> Parse (string input)
                 }
                 else
                 {
-                    return null;
+                    throw new System.IO.IOException("No available networks found, please ensure that your device is in scanning mode.");
                 }
             }
             finally