Move and refactor meadow cloud login to meadow login
#497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the
meadow cloud loginandmeadow cloud logoutcommands to remove thecloudportion from the commands. It also includes refactoring since thelogincommand no longer reaching out to Meadow.Cloud to retrieve the user from there. Instead, that responsibility is passed to theBaseCloudCommand<T>base class. This also reduces the amount of duplicate code by moving the--hostarugment inBaseCloudCommand<T>. It also introduces to methods that can be used in deriving classes:PreAuthenticatedValidationandExecuteCloudCommand. The former provides a way to run validation checks before authentication takes place. The latter is executed after the user is authenticated (or gives an error if they are not).