Deploy linked binaries if available + some cleanup #472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctacke
approved these changes
Feb 14, 2024
stevenkuhn
reviewed
Feb 14, 2024
| @@ -14,12 +15,12 @@ private static bool MatchingDllExists(string file) | |||
|
|
|||
| private static bool IsPdb(string file) | |||
| { | |||
| return String.Compare(Path.GetExtension(file), ".pdb", StringComparison.OrdinalIgnoreCase) == 0; | |||
| return string.Compare(Path.GetExtension(file), ".pdb", StringComparison.OrdinalIgnoreCase) == 0; | |||
There was a problem hiding this comment.
Is bool string.Equals(string, string, StringComparison) available here?
There was a problem hiding this comment.
yeah the CLI is a .NET 8 app so I get the fancy APIs ;)
| if (File.Exists(rootFolder)) | ||
| { | ||
| rootFolder = Path.GetDirectoryName(rootFolder) ?? ""; // extreact the folder name or if invalid, use the current directory. | ||
| rootFolder = Path.GetDirectoryName(rootFolder) ?? ""; // extreact the folder name or if invalid, use the current directory |
There was a problem hiding this comment.
Small nit on "extreact"
There was a problem hiding this comment.
nice - I'll fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.