Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linker refactor and v2 refresh #418

Merged
merged 1 commit into from
Dec 23, 2023
Merged

Linker refactor and v2 refresh #418

merged 1 commit into from
Dec 23, 2023

Conversation

adrianstevens
Copy link
Contributor

No description provided.

@CartBlanche
Copy link
Collaborator

CartBlanche commented Dec 21, 2023

@adrianstevens: apparently your changes make use of "primary constructors" which is currently in preview. Keep in mind that the Windows extension is still net 4.7.2 (I'm looking into seeing if MS have pulled their finger out to allow newer .NET versions in extensions), so even though the CLI might build, the extension might not. I was recently bitten by a similar issue in another PR :/.

I think we need to standardise what .NET versions we should be targetting across the board. Using preview might be cool, but might not be great for stability. Should we say highest we can stable release? Is there another metric we can use?

CC @ctacke for visibility.

@adrianstevens
Copy link
Contributor Author

Absolutely - no need for the primary ctor, I was just playing with the feature

@adrianstevens
Copy link
Contributor Author

and fixed

@adrianstevens adrianstevens merged commit e888604 into develop Dec 23, 2023
3 of 4 checks passed
@adrianstevens adrianstevens deleted the linker branch December 23, 2023 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants