Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve dependency filter for App.dll #403

Merged
merged 1 commit into from
Nov 23, 2023
Merged

improve dependency filter for App.dll #403

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions Meadow.CLI.Core/Devices/MeadowLocalDevice.FileManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -651,9 +651,8 @@ async Task AddFile(string file, bool includePdbs)
}

var dependencies = AssemblyManager.GetDependencies(fileName, directoryName, osVersion)
.Where(x => x.Contains("App.") == false)
// .Where(x => dllLinkIngoreList.Any(f => x.Contains(f)) == false)
.ToList();
.Except(new string[] { "App.dll", "App.exe" })
adrianstevens marked this conversation as resolved.
Show resolved Hide resolved
.ToList();

var trimmedDependencies = await AssemblyManager.TrimDependencies(fileName, directoryName, dependencies, noLink, Logger, includePdbs: includePdbs, verbose: verbose);

Expand Down