Do a directory existing check before we check for internet. #401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CartBlanche
force-pushed
the
dominique-FixForPaul
branch
from
c19d63e
to
c3450f9
Compare
| if (CreateFolder(local_path, force) == false) | ||
| local_path = Path.Combine(FirmwareDownloadsFilePathRoot, version); | ||
|
|
||
| if (!CreateFolder(local_path, force) && Directory.EnumerateFiles(local_path).Any()) |
There was a problem hiding this comment.
Yeah this is interesting ... at least validate there's one file. Part of me wonders if we just remove the "force" and always overwrite. I wonder if we're providing any value with the force flag? (something to chat about at least)
adrianstevens
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.